New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump external binaries to 1.2.2 #10298

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
7 participants
@joshaber
Contributor

joshaber commented Aug 18, 2017

This is to pick up the fix to Squirrel/Squirrel.Mac#212.

@joshaber

This comment has been minimized.

Contributor

joshaber commented Aug 18, 2017

I'll be out for a couple weeks, but it'd be great to get this in once CI is functional again.

@lukeapage

This comment has been minimized.

Contributor

lukeapage commented Aug 24, 2017

@zcbenz any chance we can merge this before cutting 1.8.0 ?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 24, 2017

👍

@zcbenz zcbenz merged commit 6a93052 into master Aug 24, 2017

3 of 10 checks passed

electron-mas-x64 Build #4885 failed in 33 min
Details
electron-osx-x64 Build #4879 failed in 47 min
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
electron-linux-arm Build #7689595 queued
Details
electron-linux-arm64 Build #7689596 queued
Details
electron-linux-ia32 Build #7689597 queued
Details
electron-linux-x64 Build #7689598 queued
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-win-ia32 Build #3902 succeeded in 19 min
Details
electron-win-x64 Build #3898 succeeded in 44 min
Details

@zcbenz zcbenz deleted the update-external-binaries branch Aug 24, 2017

@poiru

This comment has been minimized.

Member

poiru commented Sep 13, 2017

@zcbenz Any chance we could include this for the next 1.7.x release (see also #10071)?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 13, 2017

@jkleinsc This seems to worth backporting to 1.7.x.

@50Wliu

This comment has been minimized.

Contributor

50Wliu commented Dec 14, 2017

@zcbenz is there still a plan to backport this? It doesn't look like 1.7 line contains this fix.

@jkleinsc

This comment has been minimized.

Contributor

jkleinsc commented Dec 14, 2017

@50Wliu this was backported to 1.7 via #10628 and is available in the 1.7.9 release

@50Wliu

This comment has been minimized.

Contributor

50Wliu commented Dec 14, 2017

@jkleinsc Ah, perfect! Was looking at the tags for this PR and didn't notice there was a separate backport PR..

@devtobo

This comment has been minimized.

devtobo commented Dec 14, 2017

I can also confirm that it works (asking for admin password when updating an app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment