New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on japanese document #10304

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
@kyo-ago
Contributor

kyo-ago commented Aug 19, 2017

Original text

The proxyRules has to follow the rules below:

To japanese text

`proxyRules`は次のルールに従います。

つふぃ is not japanese word)

@welcome

This comment has been minimized.

welcome bot commented Aug 19, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zeke

This comment has been minimized.

Member

zeke commented Aug 21, 2017

Thanks for your contribution!

I wanted to let you know that we're working on a new system for translating Electron's docs. See readme at electron/electron-i18n for info on how to get started, or you can jump right into translating at https://crowdin.com/project/electron

@zeke zeke merged commit a50e36d into electron:master Aug 21, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@welcome

This comment has been minimized.

welcome bot commented Aug 21, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@kyo-ago kyo-ago deleted the kyo-ago:patch-1 branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment