New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for indicators in Ubuntu Gnome Session #10355

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@owais
Contributor

owais commented Aug 25, 2017

Ubuntu is switching to Gnome in 17.10 but it's not going to be the stock Gnome session. It's going to support the existing Unity APIs. Support has already landed for application indicators and likely other APIs (Launcher,etc) will be supported soon. The Ubuntu Gnome session will have XDG_CURRENT_DESKTOP=ubuntu:GNOME environment variable.

Ref: https://didrocks.fr/2017/08/23/ubuntu-gnome-shell-in-artful-day-7/

Add support for indicators in Ubuntu Gnome Session
Ubuntu is switching to Gnome in 17.10 but it's not going to be the stock Gnome session. It's going to support the existing Unity APIs. Support has already landed for application indicators and likely other APIs (Launcher,etc) will be supported soon. The Ubuntu Gnome session will have `XDG_CURRENT_DESKTOP=ubuntu:GNOME` environment variable.

Ref: https://didrocks.fr/2017/08/23/ubuntu-gnome-shell-in-artful-day-7/
@welcome

This comment has been minimized.

welcome bot commented Aug 25, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zcbenz

zcbenz approved these changes Sep 12, 2017

Looks good to me.

@zcbenz zcbenz merged commit 6ebd002 into electron:master Sep 12, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@welcome

This comment has been minimized.

welcome bot commented Sep 12, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@3v1n0

This comment has been minimized.

Contributor

3v1n0 commented on dc43dc2 Oct 12, 2017

Proper fix to this sould be done in libchromiumcontent though, and even better it should be check for dbus interfaces more than this.

kwonoj added a commit to kwonoj/electron that referenced this pull request Jan 25, 2018

Add Support for Pop!_OS GNOME Session
Similar to this PR: electron#10355 , Pop!_OS suffers from the same problem. Using Ubuntu AppIndicator will not show the icon currently unless the XDG_CURRENT_DESKTOP variable is modified. This commit will add support for pop so that this workaround is not needed. 

Ref: pop-os/pop#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment