New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mouse-move event and click event position for tray #10361

Merged
merged 3 commits into from Oct 5, 2017

Conversation

Projects
None yet
6 participants
@sbannigan
Contributor

sbannigan commented Aug 26, 2017

Similar to #9760 - Adds API for listening to mouse-move events for Tray. Also adds position for the Tray click event. This allows for more precise hover states and click events on the tray icon.

@welcome

This comment has been minimized.

welcome bot commented Aug 26, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@vanessayuenn

lgtm 👍

@zeke

zeke approved these changes Oct 4, 2017

I can't vouch for the code changes, but the new docs look great to me.

I wonder if it would be useful to have a general purpose event emitter for all mouse movement, not just over the tray icon.

cc @Toinane

@zcbenz

zcbenz approved these changes Oct 5, 2017

@sbannigan sbannigan requested review from electron/docs as code owners Oct 5, 2017

@zcbenz zcbenz merged commit 80e6a64 into electron:master Oct 5, 2017

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
electron-mas-x64 Build #5314 succeeded in 13 min
Details
electron-osx-x64 Build #5300 succeeded in 18 min
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 5, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@Toinane

This comment has been minimized.

Member

Toinane commented Oct 5, 2017

Yeah, it would be really great to make a global event emitter of mouse move/click! It's really a thing I need for some projects :)

@gclsoft

This comment has been minimized.

gclsoft commented Sep 24, 2018

https://electronjs.org/docs/api/tray#event-mouse-enter-macos
event-mouse-enter is works only on mac, not on Windows, right??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment