New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark filters as optional inside webRequest #10454

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Sep 7, 2017

@MarshallOfSound MarshallOfSound requested a review from zeke Sep 7, 2017

@zeke

This comment has been minimized.

Member

zeke commented Sep 7, 2017

See this on Travis:

test/main.ts(908,21): error TS2345: Argument of type '{ productName: string; companyName: string; submitURL: string; uploadToServer: true; extra: { som...' is not assignable to parameter of type 'CrashReporterStartOptions'.
  Property 'crashesDirectory' is missing in type '{ productName: string; companyName: string; submitURL: string; uploadToServer: true; extra: { som...'.
test/renderer.ts(105,21): error TS2345: Argument of type '{ productName: string; companyName: string; submitURL: string; uploadToServer: true; }' is not assignable to parameter of type 'CrashReporterStartOptions'.
  Property 'crashesDirectory' is missing in type '{ productName: string; companyName: string; submitURL: string; uploadToServer: true; }'.

Seems unrelated though? Restarting the Travis build now...

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Sep 8, 2017

@zeke That might have been my bad with a previous PR, lemme check

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Sep 8, 2017

Yup, all fixed now @zeke

@zeke zeke merged commit fbfd781 into master Sep 8, 2017

5 of 6 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5039 succeeded in 14 min
Details
electron-osx-x64 Build #5025 succeeded in 12 min
Details
electron-win-ia32 Build #4074 succeeded in 19 min
Details
electron-win-x64 Build #4060 succeeded in 14 min
Details

@zeke zeke deleted the MarshallOfSound-patch-1 branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment