Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app.getGPUFeatureStatus in app.md #10499

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
2 participants
@miniak
Copy link
Contributor

miniak commented Sep 12, 2017

getGPUFeatureStatus is incorrectly documented as getGpuFeatureStatus, therefore electron.d.ts contains an incorrect method signature.

in atom/browser/api/atom_api_app.cc

      .SetMethod("getGPUFeatureStatus", &App::GetGPUFeatureStatus)

@miniak miniak requested a review from alespergl Sep 12, 2017

@alespergl
Copy link
Contributor

alespergl left a comment

Seems legit :)

@miniak miniak merged commit ddb1d92 into electron:master Sep 12, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@miniak miniak deleted the miniak:doc-fix branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.