New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NativeWindowMac): addTabbedWindow #10508

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@danielma
Contributor

danielma commented Sep 13, 2017

Add support for the NSWindow addTabbedWindow method on MacOSX

This plays nicely with the changes from #9052 and #9725

Usage samples available in this commit in my fork ofelectron-quick-start

Fixes #9094

danielma and others added some commits Sep 13, 2017

feat(NativeWindowMac): addTabbedWindow
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX

This plays nicely with the changes from #9052 and #9725

Usage samples available in [this commit][c] in my fork of
`electron-quick-start`

[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: danielma/electron-quick-start@79f0659

@danielma danielma requested review from electron/docs as code owners Oct 3, 2017

@zcbenz

zcbenz approved these changes Oct 3, 2017

@zcbenz zcbenz merged commit 745fa70 into electron:master Oct 3, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@danielma danielma deleted the danielma:dma/native-tab-new-button branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment