Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix examples for sandbox #10509

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Projects
None yet
2 participants
@kewde
Copy link
Contributor

commented Sep 13, 2017

w -> win

Fix examples
w -> win
@welcome

This comment has been minimized.

Copy link

commented Sep 13, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@kewde kewde changed the title Fix examples docs: fix examples for sandbox Sep 13, 2017

@miniak

miniak approved these changes Sep 17, 2017

@miniak miniak merged commit 9cfadbe into electron:master Sep 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

commented Sep 17, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@kewde kewde deleted the kewde:patch-1 branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.