New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed potential crash in Win32 notifications. #10516

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@alespergl
Contributor

alespergl commented Sep 14, 2017

There's a potential crash when iterating over toast instances where a null pointer is dereferenced in case an instance's HWND has already been destroyed.

This is a backport candidate to previous releases which have Windows 7 notifications.

@alespergl alespergl requested a review from zcbenz Sep 21, 2017

@zcbenz

zcbenz approved these changes Sep 22, 2017

@zcbenz zcbenz merged commit ec58703 into master Sep 22, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5101 succeeded in 12 min
Details
electron-osx-x64 Build #5084 succeeded in 12 min
Details

@zcbenz zcbenz deleted the fix_notification_crash branch Sep 22, 2017

@walltex

This comment has been minimized.

walltex commented Nov 1, 2017

@zcbenz Do you know when this fix will be released and in which version of Electron (1.6., 1.7, 1.8)?

@Anrock

This comment has been minimized.

Anrock commented Mar 27, 2018

@zcbenz as far as i understand this fix is released in 1.8.1, is there plans to backport it to 1.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment