Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add npx command for node version 8.2.0 and later in quickstart guide #10534

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@Hinara
Copy link
Contributor

Hinara commented Sep 16, 2017

Add the npx command to quickstart guide
It avoids going to the node_modules folder to execute

@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 16, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@Hinara Hinara changed the title Add npx command for node version 8.2.0 and later in quickstart guide [Docs] Add npx command for node version 8.2.0 and later in quickstart guide Sep 16, 2017

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Sep 16, 2017

I think this should be the last option not the first (at least for now). npx isn't widely adopted yet afaik (node LTS is still on npm@3)

robbix1206
@Hinara

This comment has been minimized.

Copy link
Contributor Author

Hinara commented Sep 16, 2017

I know, but npx is so practical 😄
I put it on the first place as most people read that like code with if statement, most of them will take the first option which corresponds.
So yes for now npx is not really adopted, but I hope it will as the command is a lot shorter and manage local and global npm installed packet. (Even if npx 9.2.1 prompt errors on windows even if it works)

@codebytere
Copy link
Member

codebytere left a comment

if you've tested this and it works then it looks 💯

@jkleinsc jkleinsc merged commit 51cbd97 into electron:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 18, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.