New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting changes for 1.7.8 #10586

Merged
merged 12 commits into from Sep 23, 2017

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Sep 23, 2017

Pulls in:

/cc @jkleinsc

MarshallOfSound and others added some commits Sep 14, 2017

Fix app.makeSingleInstance hanging on posix systems
Wait for the IO thread to be a thing before attempting to listen on the socket

Fixes #9880
Refactor as per @zcbenz comments
Also fix issue where we run the single instance callback *not* on the UI thread,
this apparently results in a hung process.
Fix missing extension when saving a file without filters
Previously, when triggering the save dialog through e.g. `<a download>`
links (e.g. http://jsfiddle.net/koldev/cW7W5/), the extension was only
saved if Finder was set to show all extensions by default. We now always
display the extension to make sure that it is saved.

If we want to keep the extension hidden, we could also populate the
allowed file types array with the extension from the default filename,
but that would have interfered with how we set the filters.

@MarshallOfSound MarshallOfSound changed the base branch from master to 1-7-x Sep 23, 2017

jkleinsc and others added some commits Sep 23, 2017

@jkleinsc jkleinsc merged commit b15392e into 1-7-x Sep 23, 2017

5 of 6 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
electron-mas-x64 Build #5158 succeeded in 11 min
Details
electron-osx-x64 Build #5143 succeeded in 11 min
Details

@jkleinsc jkleinsc deleted the 1-7-8-backporting branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment