New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `string` to notification doc #10612

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@felixrieseberg
Member

felixrieseberg commented Sep 25, 2017

Tiny fix: The docs suggest NativeImage for icon, but a string is also allowed.

Add `string` to notification doc
Tiny fix: The docs suggest `NativeImage` for `icon`, but a string is also allowed.

@felixrieseberg felixrieseberg requested a review from zeke Sep 25, 2017

@codebytere codebytere self-requested a review Oct 17, 2017

@codebytere

Looks 💯

@zeke zeke merged commit a914d3c into master Oct 17, 2017

7 of 8 checks passed

electron-osx-x64 Build #5181 in progress...
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5197 succeeded in 12 min
Details

@codebytere codebytere deleted the notification-docs-fix branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment