New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drag fullscreen window #10627

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented Sep 27, 2017

When using webkit-app-region: drag together with BrowserViews, one is able to move the window even when in fullscreen mode. Trippy, right?

The reason is that we're moving the window manually on older versions of macOS that do not support the native performWindowDragWithEvent. This PR adds a quick check if we're in fullscreen mode - which cancels a move when in fullscreen mode.

@@ -47,6 +47,10 @@ - (void)mouseDown:(NSEvent *)event
return;
}
if (([self.window styleMask] & NSFullScreenWindowMask) == NSFullScreenWindowMask) {

This comment has been minimized.

@poiru

poiru Sep 27, 2017

Member

Nit: [self.window styleMask] & NSFullScreenWindowMask should be sufficient.

@poiru

poiru approved these changes Sep 27, 2017

LGTM, thanks for fixing this!

@felixrieseberg felixrieseberg merged commit 04373b8 into master Sep 27, 2017

7 of 8 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5232 succeeded in 12 min
Details
electron-osx-x64 Build #5217 succeeded in 13 min
Details

@felixrieseberg felixrieseberg deleted the fullscreen-drag branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment