New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call GetIdleWakeupsPerSecond on Win #10680

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Oct 3, 2017

On Windows, the system doesn't keep track of idle wakeups the same way Unix does - so Chromium throws a nasty NOTIMPLEMENTED() every single time we call process.getCPUUsage() on Windows. Nothing crashes, but it pollutes the log with lines like these:

[1288:1003/084000.939:ERROR:process_metrics.cc(99)] NOT IMPLEMENTED

This PR makes sure that we don't even attempt this not implemented call. Instead, we return 0, keeping the current behavior around.

@felixrieseberg felixrieseberg requested review from electron/docs as code owners Oct 3, 2017

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Oct 4, 2017

The macOS failures seem unrelated, but also seem broken on master. Will raise an issue to track that down 👍

@felixrieseberg felixrieseberg merged commit a337b12 into master Oct 4, 2017

6 of 8 checks passed

electron-mas-x64 Build #5294 failed in 19 min
Details
electron-osx-x64 Build #5280 failed in 22 min
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@felixrieseberg

This comment has been minimized.

Member

felixrieseberg commented Oct 4, 2017

Thanks!

@felixrieseberg felixrieseberg deleted the idlewakeups-windows branch Oct 4, 2017

@zeke

This comment has been minimized.

Member

zeke commented Oct 4, 2017

Thanks for fast-tracking this, @deepak1556 and @MarshallOfSound 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment