New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove potential deprecation and fix app close #10712

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Oct 7, 2017

per conversation with last night, move to remove deprecation warning and simply show help information alongside opening default app when electron is run with no args

/cc @MarshallOfSound @zeke

@codebytere codebytere requested a review from electron/docs as a code owner Oct 7, 2017

@zeke zeke merged commit c85b159 into master Oct 8, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5347 succeeded in 12 min
Details
electron-osx-x64 Build #5334 succeeded in 13 min
Details

@zeke zeke deleted the remove-default-deprecation branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment