New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed font DPI scaling #10715

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@alespergl
Contributor

alespergl commented Oct 9, 2017

Fixes #9665

@alespergl alespergl requested a review from electron/notifications as a code owner Oct 9, 2017

inline T ScaleForDpi(T value, unsigned dpi) {
return value * dpi / 96;
constexpr T ScaleForDpi(T value, unsigned dpi, unsigned source_dpi = 96) {
return value * dpi / source_dpi;

This comment has been minimized.

@felixrieseberg

felixrieseberg Oct 9, 2017

Member

YES! Thank you.

@felixrieseberg

This comment has been minimized.

Member

felixrieseberg commented Oct 9, 2017

Looks wonderful to me, let's merge this in.

@zeke zeke merged commit 19ac217 into master Oct 9, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5358 succeeded in 12 min
Details
electron-osx-x64 Build #5345 succeeded in 13 min
Details

@zeke zeke deleted the fix_toast_dpi_scaling branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment