New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix Korean translation's minor mistakes #10777

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@revi
Contributor

revi commented Oct 12, 2017

Mostly spacing error, one Markdown error.

WIP, I plan to have a look at the whole translation this weekend or later next week.

Fix Korean grammatic mistakes
Mostly spacing errors. Haven't look at full Korean translation, but
will do.

Signed-off-by: Yongmin Hong <revi@pobox.com>
@welcome

This comment has been minimized.

welcome bot commented Oct 12, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zeke

This comment has been minimized.

Member

zeke commented Oct 13, 2017

Thanks for your contribution!

I wanted to let you know that we're working on a new system for translating Electron's docs. See the readme at electron/electron-i18n for info on how to get started, or you can jump right into translating at https://crowdin.com/project/electron

@zeke

This comment has been minimized.

Member

zeke commented Oct 13, 2017

I'm happy to merge these changes, but would advise directing your energy to https://crowdin.com/project/electron instead. 🙏

@zeke

zeke approved these changes Oct 13, 2017

@revi

This comment has been minimized.

Contributor

revi commented Oct 13, 2017

Hi, in that case just merge this and I’ll continue there!

@zeke zeke merged commit 4c9d432 into electron:master Oct 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 13, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment