Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs #10795

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@samthomson
Copy link
Contributor

samthomson commented Oct 14, 2017

added the max limit for a parameter to help people who don't know why it silently fails.
closes #9987

@samthomson samthomson requested a review from as a code owner Oct 14, 2017

@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 14, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@codebytere
Copy link
Member

codebytere left a comment

Looks good, thanks!

@zeke zeke merged commit 71f1362 into electron:master Oct 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 17, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Oct 17, 2017

Thanks, @samthomson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.