New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code to session.setCertificateVerifyProc #10810

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@qazbnm456
Contributor

qazbnm456 commented Oct 16, 2017

This PR adds errorCode value to the request object, so ppl can directly get the error code value, not just the verification result string.

@qazbnm456 qazbnm456 requested review from electron/docs as code owners Oct 16, 2017

@deepak1556

What would be the use case for it ? The error codes are chromium specific, users will have to convert them back to know what it means which will be nothing but the verification result.

@qazbnm456

This comment has been minimized.

Contributor

qazbnm456 commented Oct 17, 2017

@deepak1556 I think it's a plus for ppl who want to customize error pages for certain error codes, for it would be much easier for knowing what error we get from chromium by just comparing an error code, not a string.

@deepak1556

This comment has been minimized.

Member

deepak1556 commented Oct 17, 2017

Thanks for the explanation! But these are not standard error codes, so I don't expect users to customize based on them. But given that we already provide error code in other existing events, its fine to add this.

@zeke

zeke approved these changes Oct 17, 2017

@jkleinsc jkleinsc merged commit 57537ea into electron:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@qazbnm456 qazbnm456 deleted the qazbnm456:add_error_code_to_session_set_certificate_verify_proc branch Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment