New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to show usage of ipcRenderer.sendTo #10829

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@zombieleet
Contributor

zombieleet commented Oct 18, 2017

No description provided.

@zombieleet zombieleet requested a review from electron/docs as a code owner Oct 18, 2017

@welcome

This comment has been minimized.

welcome bot commented Oct 18, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@@ -74,6 +74,14 @@ and replies by setting `event.returnValue`.
**Note:** Sending a synchronous message will block the whole renderer process,
unless you know what you are doing you should never use it.
### `ipcRenderer.sendTo(windowid, channel, [, arg1][, arg2][, ...])`
* `windowid` Number

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Oct 18, 2017

Member

/nit windowId (camelCase)

This comment has been minimized.

@zombieleet

zombieleet Oct 18, 2017

Contributor

have you made the changes ?

@jkleinsc jkleinsc merged commit a65ab1d into electron:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 18, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment