New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSR with more details #10874

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@Toinane
Member

Toinane commented Oct 21, 2017

I've added some details about OSR :)

@Toinane Toinane requested a review from electron/docs as a code owner Oct 21, 2017

@Toinane Toinane self-assigned this Oct 21, 2017

@Toinane Toinane requested a review from zeke Oct 23, 2017

@ckerr

Thank you for filling out this entry and for fixing the entry's markdown header level 👍

A couple of minor grammar suggestions:

  • 'e.g.' means 'for example' so this reads "for for example". Better to say something like "can be used for loading a heavy page in the background ..."
  • 'much more faster' -> 'faster' or 'much faster'
  • 'without show on screen' -> 'without showing it on screen'
@Toinane

This comment has been minimized.

Show comment
Hide comment
@Toinane

Toinane Oct 23, 2017

Member

thank you for your reply :) I've fixed the grammar issue 👍

Member

Toinane commented Oct 23, 2017

thank you for your reply :) I've fixed the grammar issue 👍

@ckerr

ckerr approved these changes Oct 23, 2017

@zeke zeke merged commit 1672fd2 into electron:master Oct 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Oct 23, 2017

Member

merci @Toinane 👌

Member

zeke commented Oct 23, 2017

merci @Toinane 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment