New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering issues with Nvidia GPU on High Sierra for 1.7.x #10898

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@jkleinsc
Contributor

jkleinsc commented Oct 24, 2017

This fix pulls in a patch to fix rendering issues with Nvidia GPU on High Sierra in 1.7.x

See https://bugs.chromium.org/p/chromium/issues/detail?id=773705 for more details

@jkleinsc jkleinsc changed the title from Fix rendering issues with Nvidia GPU on High Sierra to Fix rendering issues with Nvidia GPU on High Sierra for 1.7.x Oct 24, 2017

@ckerr

ckerr approved these changes Oct 27, 2017

Same comment as in master: approving as patch looks sane given upstream discussion, but have not personally tested on High Sierra. @jkleinsc if you've confirmed the fix, I'm ok with you merging these

@skllcrn

This comment has been minimized.

skllcrn commented Nov 2, 2017

@jkleinsc @alexeykuzmin based on my own testing and the ongoing discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=773705, disabling GPU rasterization and accelerated 2D canvas does not solve the issue.

Allow blacklisting of use of GpuMemoryBuffers as render targets.
Disable this on macOS 10.13 when NVIDIA GPUs are in use. Based on
experiments with WebGL, it strongly seems that the bugs introduced in
this OS release are not tied to GPU rasterization or accelerated 2D
canvas, but rather caused by rendering into IOSurfaces via OpenGL.
Re-enable accelerated 2D canvas and GPU rasterization on this
configuration.

I've tested again with the latest NVIDIA drivers on macOS 10.13.1 and I'm still seeing flickering issues on http://webglsamples.org/multiple-views/multiple-views.html with both Stable 62 and Canary 64.

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 2, 2017

@skllcrn Yeah, we keep following that issue in the Chromium tracker.
I guess the only thing we can do is to wait for a proper fix from Apple/Nvidia.
In a meanwhile we can try this temporary solution, there were reports saying it did help some people.

@ckerr ckerr merged commit b15c418 into 1-7-x Nov 13, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
electron-mas-x64 Build #5692 succeeded in 10 min
Details
electron-osx-x64 Build #5663 succeeded in 12 min
Details

@ckerr ckerr deleted the nvidia-high-sierra-17x-fix branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment