New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that -r isn’t considered interactive #10900

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented Oct 25, 2017

Starting with 1.8, we activated interactive mode for the -r parameter, which according to docs should just require a module.

I think that was just a typo that we all missed, but I'll let @codebytere confirm.

Fixes #10877

@felixrieseberg felixrieseberg requested a review from codebytere Oct 25, 2017

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner Oct 25, 2017

@felixrieseberg felixrieseberg changed the title from f: Ensure that -r isn’t considered interactive to fix: Ensure that -r isn’t considered interactive Oct 25, 2017

@codebytere

Yep, -r shouldn't be a flag for two different things!

@felixrieseberg felixrieseberg merged commit 8d1ff1c into master Oct 25, 2017

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
electron-mas-x64 Build #5497 succeeded in 12 min
Details
electron-osx-x64 Build #5480 succeeded in 13 min
Details

@felixrieseberg felixrieseberg deleted the issue-10877 branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment