New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:penguin: Don't wait for xdg-open to exit #10902

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@mattlyons0
Contributor

mattlyons0 commented Oct 25, 2017

Waiting for xdg-open to return freezes Electron application.
Some file managers (ex: Nemo) don't return until some time after they are closed, this freezes the Electron application until the process returns.
The same is true about any application that can potentially be opened with OpenItem.

Is there any reason why this was set to true initially? It was introduced in this commit and it seems that it was just sent to true because the author didn't have a problem with applications opened with OpenItem or ShowItemInFolder hanging. It turns out this is easily reproducible when Nemo is the default file manager or you open a item with a default application that does not return from the xdg-open call immediately.

I have seen this in mattlyons0/Assessorator#4 and verified this PR fixes the behavior. Additionally I believe this fixes Foundry376/Mailspring#156 (although I cannot verify because I can't get it to build with a different electron version successfully).

🐧 Don't wait for xdg-open to exit
Waiting for xdg-open to return freezes Electron application.
Some file managers (ex: Nemo) don't return until some time after they are closed, this freezes the Electron application until the process returns.
The same is true about any application that can potentially be opened with OpenItem

@mattlyons0 mattlyons0 requested a review from electron/reviewers as a code owner Oct 25, 2017

@zcbenz

zcbenz approved these changes Oct 26, 2017

I'm good with this, /cc @ckerr.

@ckerr

ckerr approved these changes Oct 26, 2017

LGTM too.

@ckerr ckerr merged commit c72e0c1 into electron:master Oct 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment