Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
:penguin: Don't wait for xdg-open to exit #10902
Waiting for xdg-open to return freezes Electron application.
Is there any reason why this was set to true initially? It was introduced in this commit and it seems that it was just sent to true because the author didn't have a problem with applications opened with OpenItem or ShowItemInFolder hanging. It turns out this is easily reproducible when Nemo is the default file manager or you open a item with a default application that does not return from the xdg-open call immediately.
I have seen this in mattlyons0/Assessorator#4 and verified this PR fixes the behavior. Additionally I believe this fixes Foundry376/Mailspring#156 (although I cannot verify because I can't get it to build with a different electron version successfully).