New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering issues with Nvidia GPU on High Sierra #10923

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Oct 26, 2017

This fix pulls in a patch to fix rendering issues with Nvidia GPU on High Sierra.

See https://bugs.chromium.org/p/chromium/issues/detail?id=773705 for more details

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Oct 26, 2017

@ckerr

ckerr approved these changes Oct 26, 2017

The patch looks reasonable to me given the linked upstream discussion, so approving at that level.

I have not tested the resulting build, @jkleinsc or anyone else who wants to confirm, that would be great...

@bpasero

This comment has been minimized.

Contributor

bpasero commented Nov 4, 2017

@jkleinsc fyi it seems that meanwhile a new patch is proposed which is a more isolated fix (but unfortunately much larger change) of the problem. See https://bugs.chromium.org/p/chromium/issues/detail?id=773705#c91

@ckerr

This comment has been minimized.

Member

ckerr commented Nov 14, 2017

Since the upstream fix for this is pretty large and hasn't landed yet, IMO we should use this workaround as an interim solution.

@MarshallOfSound, do we have a preferred way of leaving breadcrumbs for the project to remember to remove this workaround when we upgrade to a fixed upstream libcc? Filing a ticket seems like the obvious option...

@ckerr ckerr merged commit bbde795 into master Nov 14, 2017

7 of 9 checks passed

ci/circleci: electron-linux-x64 Your CircleCI tests were canceled
Details
electron-osx-x64 Build #5664 failed in 9 min 34 sec
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5693 succeeded in 12 min
Details

@ckerr ckerr deleted the nvidia-high-sierra-fix branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment