New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the click event is only dispatched on ContentsClicked activation type #10943

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Oct 27, 2017

Fixes #10940

@MarshallOfSound MarshallOfSound requested a review from electron/notifications as a code owner Oct 27, 2017

@codebytere

💯

@MarshallOfSound MarshallOfSound merged commit 5c6d418 into master Oct 27, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5552 succeeded in 12 min
Details
electron-osx-x64 Build #5531 succeeded in 13 min
Details

@MarshallOfSound MarshallOfSound deleted the ensure-contents-clicked branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment