New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test `getBrowserView` #10953

Merged
merged 3 commits into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@felixrieseberg
Member

felixrieseberg commented Oct 27, 2017

The code is already there, it just wasn't documented or tested.

Fixes #10921

@felixrieseberg felixrieseberg requested a review from poiru Oct 27, 2017

@felixrieseberg felixrieseberg requested review from electron/docs as code owners Oct 27, 2017

@poiru

poiru approved these changes Oct 27, 2017

Thanks!

@jkleinsc

Looks good to me.

@jkleinsc jkleinsc merged commit 04cce89 into master Oct 27, 2017

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #5573 succeeded in 12 min
Details
electron-osx-x64 Build #5553 succeeded in 13 min
Details

@jkleinsc jkleinsc deleted the get-browser-view branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment