New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't call idleWakeupsPerSecond on Windows #10954

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented Oct 27, 2017

On Windows, the system doesn't keep track of idle wakeups the same way Unix does - so Chromium throws a nasty NOTIMPLEMENTED() every single time we call getAppMetrics() on Windows. Nothing crashes, but it pollutes the log with lines like these:

[1288:1003/084000.939:ERROR:process_metrics.cc(99)] NOT IMPLEMENTED

This PR makes sure that we don't even attempt this not implemented call. Instead, we return 0, keeping the current behavior around.

We've done this before for the explicit call (#10680), but missed this one.

@felixrieseberg felixrieseberg requested a review from electron/reviewers as a code owner Oct 27, 2017

@MarshallOfSound MarshallOfSound merged commit c9926be into master Oct 27, 2017

9 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5583 succeeded in 16 min
Details
electron-osx-x64 Build #5561 succeeded in 13 min
Details

@MarshallOfSound MarshallOfSound deleted the less-process-metrics-warnings branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment