Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Korean Community #10997

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@xxczaki
Copy link
Contributor

xxczaki commented Nov 2, 2017

Meetup Group doesn't exist.

https://www.meetup.com/electron-kr/

@xxczaki xxczaki requested a review from as a code owner Nov 2, 2017

@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 2, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@xxczaki

This comment has been minimized.

Copy link
Contributor Author

xxczaki commented Nov 8, 2017

@ckerr

ckerr approved these changes Nov 8, 2017

Copy link
Member

ckerr left a comment

Thanks for this update!

@ckerr ckerr merged commit 9bf950a into electron:master Nov 8, 2017

5 of 6 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 8, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Nov 9, 2017

Thanks 👍

@sdj01044 sdj01044 referenced this pull request Nov 10, 2017

Merged

Add Korean Community #11079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.