New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Korean grammatic mistakes #11000

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@sdj01044
Contributor

sdj01044 commented Nov 3, 2017

I fixed wrong words & wrong translations.

Fix Korean grammatic mistakes
I fixed wrong words & wrong translations.
@welcome

This comment has been minimized.

welcome bot commented Nov 3, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@sdj01044

This comment has been minimized.

Contributor

sdj01044 commented Nov 7, 2017

I want to know about a check.
(ci/circleci: electron-linux-x64)

@Toinane

This comment has been minimized.

Member

Toinane commented Nov 7, 2017

@sdj01044 Hey! Thanks for your PR, I recommend you to use Crowdin for this https://crowdin.com/project/electron
because this translation folder will be deprecated soon and it easier for translators 👍

@zeke

zeke approved these changes Nov 7, 2017

@zeke zeke merged commit 8eb38be into electron:master Nov 7, 2017

5 of 6 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Nov 7, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@zeke

This comment has been minimized.

Member

zeke commented Nov 7, 2017

Thanks for your contribution, @sdj01044. Like @Toinane said, all future translation efforts should happen on Crowdin instead of this repository. See https://github.com/electron/electron-i18n#readme for more info.

@sdj01044

This comment has been minimized.

Contributor

sdj01044 commented Nov 7, 2017

Thanks for your kindness, @Toinane & @zeke.
Your detail information is very helpful to me and other contributors! 👍👍👍
(I am so glad that my first PR has been approved!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment