New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: One-character typo change #11007

Merged
merged 2 commits into from Nov 5, 2017

Conversation

Projects
None yet
3 participants
@felixrieseberg
Member

felixrieseberg commented Nov 3, 2017

I know, silly to make a PR for one character, but also silly to leave it in.

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner Nov 3, 2017

@poiru

poiru approved these changes Nov 3, 2017

@@ -200,7 +200,7 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
key is pressed. Default is `false`.
* `enableLargerThanScreen` Boolean (optional) - Enable the window to be resized larger
than screen. Default is `false`.
* `backgroundColor` String (optional) - Window's background color as Hexadecimal value,
* `backgroundColor` String (optional) - Window's background color as hexadecimal value,

This comment has been minimized.

@poiru

poiru Nov 3, 2017

Member

While you're in here, maybe an extra "a" as in "as a hexadecimal value"? 😀

@codebytere

This comment has been minimized.

Member

codebytere commented Nov 5, 2017

the failing build is resultant of something being investigated separately :)

@codebytere codebytere merged commit d1cdcc5 into master Nov 5, 2017

6 of 7 checks passed

electron-osx-x64 Build #5672 failed in 17 min
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5701 succeeded in 12 min
Details

@codebytere codebytere deleted the silly-typo-change branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment