New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate /docs-translations #11039

Merged
merged 4 commits into from Nov 10, 2017

Conversation

Projects
None yet
9 participants
@zeke
Member

zeke commented Nov 6, 2017

The /docs-translations directory was a home-grown effort to translate Electron's docs. It has undoubtedly helped many folks learn Electron, but we never had a real process for keeping the translations up to date and consistent across locales. Until now!

The new Electron website is internationalized, and it consumes translated (and source) content from electron/electron-i18n, a repo that syncs with Crowdin, our new localization service.

This PR:

  • removes all existing content in the /docs-translations directory
  • keeps the directory around, and adds an explanatory README with info about the new translation process
  • documents steps for getting good-ol-days raw, offline, localized, Markdown docs.

@electron/i18n @electron/docs @sethlu

@vanessayuenn

This comment has been minimized.

Show comment
Hide comment
@vanessayuenn

vanessayuenn Nov 7, 2017

Contributor

@zeke do you think it will be possible/worth the effort to programmatically salvage some of the existing doc translations and import them into the new crowdin system? Just tossing them seems like such a waste of old translation effort.

Contributor

vanessayuenn commented Nov 7, 2017

@zeke do you think it will be possible/worth the effort to programmatically salvage some of the existing doc translations and import them into the new crowdin system? Just tossing them seems like such a waste of old translation effort.

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 7, 2017

Member

do you think it will be possible/worth the effort to programmatically salvage some of the existing doc translations

@alebourne and I discussed this with the Crowdin team and the consensus seemed to be that it would be too hard. That said, I would not be opposed to giving it a try.

Member

zeke commented Nov 7, 2017

do you think it will be possible/worth the effort to programmatically salvage some of the existing doc translations

@alebourne and I discussed this with the Crowdin team and the consensus seemed to be that it would be too hard. That said, I would not be opposed to giving it a try.

@Toinane

This comment has been minimized.

Show comment
Hide comment
@Toinane

Toinane Nov 7, 2017

Member

I would add that the translations (e.g. french translations) are no longer up to date for most files or I already copy them into Crowdin when I can for the french one. But it can be useful for others languages who have recent translations.

Member

Toinane commented Nov 7, 2017

I would add that the translations (e.g. french translations) are no longer up to date for most files or I already copy them into Crowdin when I can for the french one. But it can be useful for others languages who have recent translations.

@natebwangsut

This comment has been minimized.

Show comment
Hide comment
@natebwangsut

natebwangsut Nov 7, 2017

Contributor

Agreed. @Toinane

A lot of the translation are no longer up to date. Personally I do think by using the whole new interface from Crowdin makes the recent translation much more consistent as we have access to the language guideline and commonly agreed terms.

Beside that, some of the vocab that reflect the context more expressively could be retrieved from the old docs and use it in the new one. However, it would be programmatically hard to do so.

Contributor

natebwangsut commented Nov 7, 2017

Agreed. @Toinane

A lot of the translation are no longer up to date. Personally I do think by using the whole new interface from Crowdin makes the recent translation much more consistent as we have access to the language guideline and commonly agreed terms.

Beside that, some of the vocab that reflect the context more expressively could be retrieved from the old docs and use it in the new one. However, it would be programmatically hard to do so.

@TiagoDanin

Translation management on Crowdin is better! 👍1+

@alebourne

This comment has been minimized.

Show comment
Hide comment
@alebourne

alebourne Nov 7, 2017

Hi @zeke and team members,
Recently,I reached out to Crowdin AGAIN about trying to salvage translations done outside the system. They have told me this is now possible. Here is the information I got from them:
My question was:

We have several existing translation repositories that already exist. The community members had translated these documents by cloning a repo and then translate them. We want to move them to Crowdin. Is there any way to reuse the translations that have already been completed?

The Crowdin answer was:

Regarding the existing translations, the suggested workflow might be the following:

  1. please download the translations from each repository on your computer and place them in the ZIP archive;
  2. after that, please upload ZIP archive as the existing translations to your project (https://support.crowdin.com/uploading-translations/)
  3. finally, it is necessary to invite the owners of the repositories as the translators. As a result, they will be able to continue working on the translations directly in Crowdin

Also, I have a glossary that we have completed with GtHub terms that we should consider to start translation for that might be beneficial for Electron. I'm thinking we should create a separate issue to discuss.

alebourne commented Nov 7, 2017

Hi @zeke and team members,
Recently,I reached out to Crowdin AGAIN about trying to salvage translations done outside the system. They have told me this is now possible. Here is the information I got from them:
My question was:

We have several existing translation repositories that already exist. The community members had translated these documents by cloning a repo and then translate them. We want to move them to Crowdin. Is there any way to reuse the translations that have already been completed?

The Crowdin answer was:

Regarding the existing translations, the suggested workflow might be the following:

  1. please download the translations from each repository on your computer and place them in the ZIP archive;
  2. after that, please upload ZIP archive as the existing translations to your project (https://support.crowdin.com/uploading-translations/)
  3. finally, it is necessary to invite the owners of the repositories as the translators. As a result, they will be able to continue working on the translations directly in Crowdin

Also, I have a glossary that we have completed with GtHub terms that we should consider to start translation for that might be beneficial for Electron. I'm thinking we should create a separate issue to discuss.

@sethlu

This comment has been minimized.

Show comment
Hide comment
@sethlu

sethlu Nov 7, 2017

Member

@alebourne glad to hear about the news!

@zeke I'll put the copy & paste migration on block until further notice.

Member

sethlu commented Nov 7, 2017

@alebourne glad to hear about the news!

@zeke I'll put the copy & paste migration on block until further notice.

@TiagoDanin

This comment has been minimized.

Show comment
Hide comment
@TiagoDanin

TiagoDanin Nov 8, 2017

Member

@zeke Missing edit the README.md in:

Member

TiagoDanin commented Nov 8, 2017

@zeke Missing edit the README.md in:

@zeke zeke requested review from electron/docs as code owners Nov 9, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 9, 2017

Member

Missing edit the README.md

Thanks, @TiagoDanin. Fixed 👍

Member

zeke commented Nov 9, 2017

Missing edit the README.md

Thanks, @TiagoDanin. Fixed 👍

@ckerr ckerr merged commit 9291ab9 into master Nov 10, 2017

7 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ckerr ckerr deleted the deprecate-docs-translations branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment