New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate API and typescript file as artifact on CircleCI #11060

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Nov 8, 2017

This makes verifying docs changes easier

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Nov 8, 2017

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

@MarshallOfSound good idea. Would there be any benefit in storing the whole out directory and/or are there other files we should make available as well?

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Nov 8, 2017

Would there be any benefit in storing the whole out directory

I don't know if there's any limit on how much we can store but the entire out directory would be pretty large (an entire debug build of Electron + symbols). For now we can just do these, if we want to store build artifacts we can look into storing just the executables for each run maybe. (only 40mb~ish)

@ckerr

ckerr approved these changes Nov 8, 2017

Copy link
Member

ckerr left a comment

Looks good, this is a nice improvement.

(I'm guessing the test failures are due to the recent migration and not related to this MR?)

@zeke

zeke approved these changes Nov 9, 2017

@MarshallOfSound MarshallOfSound merged commit 912c023 into master Nov 9, 2017

6 of 10 checks passed

continuous-integration/jenkins/branch This commit cannot be built
Details
electron-mas-x64 Build #5779 failed in 6 min 27 sec
Details
electron-osx-x64 Build #5754 failed in 7 min 7 sec
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarshallOfSound MarshallOfSound deleted the ts-artifact branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment