Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean Community #11079

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@sdj01044
Copy link
Contributor

sdj01044 commented Nov 10, 2017

Korean Community was Pull Request #10997.

But There is a Korean Community in Slack!

So I Added it.

@sdj01044 sdj01044 requested a review from as a code owner Nov 10, 2017

@ragingwind

This comment has been minimized.

Copy link
Contributor

ragingwind commented Nov 10, 2017

@sdj01044 Would you change the url with https://electron-kr.github.io/electron-kr instead of Slack ? Slack is one of the place we(Electron Korea) using. Thanks

Dup here #11078

@sdj01044

This comment has been minimized.

Copy link
Contributor Author

sdj01044 commented Nov 10, 2017

@ragingwind Thank you! I'll change the url.

@ckerr

ckerr approved these changes Nov 10, 2017

Copy link
Member

ckerr left a comment

Thanks!

@ckerr ckerr merged commit 5adbbef into electron:master Nov 10, 2017

5 of 6 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.