New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in session docs #11126

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@numaanashraf
Contributor

numaanashraf commented Nov 15, 2017

No description provided.

@numaanashraf numaanashraf requested a review from electron/docs as a code owner Nov 15, 2017

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 15, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Nov 15, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@numaanashraf numaanashraf changed the title from :memo: Fix typo in session docs to Fix typo in session docs Nov 15, 2017

@ckerr

ckerr approved these changes Nov 15, 2017 edited

Thanks for the fix, Numaan! 👍

@ckerr ckerr merged commit 33bd2aa into electron:master Nov 15, 2017

5 of 6 checks passed

ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 15, 2017

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Nov 15, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@numaanashraf numaanashraf deleted the numaanashraf:patch-1 branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment