New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong translation link in README #11145

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
3 participants
@OuYancey
Contributor

OuYancey commented Nov 17, 2017

I see #11039 and #11100 .
Maybe we just forget the link in the top. The old links lead to 404.
I think it's better to delete all the link, only left the link electron-i18n.
But now, i just modify it to the right link.

@OuYancey OuYancey requested a review from electron/reviewers as a code owner Nov 17, 2017

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 17, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Nov 17, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 17, 2017

Member

I think it's better to delete all the link, only left the link electron-i18n.

That sounds good to me too. I would suggest something like this:

View these docs in other languages at [electron/electron-i18n](https://github.com/electron/electron-i18n/tree/master/content/).
Member

zeke commented Nov 17, 2017

I think it's better to delete all the link, only left the link electron-i18n.

That sounds good to me too. I would suggest something like this:

View these docs in other languages at [electron/electron-i18n](https://github.com/electron/electron-i18n/tree/master/content/).
@OuYancey

This comment has been minimized.

Show comment
Hide comment
@OuYancey

OuYancey Nov 17, 2017

Contributor

I just move the nation flags to replace the old nation name.
To to be consistent with electron/electron-i18n.

Contributor

OuYancey commented Nov 17, 2017

I just move the nation flags to replace the old nation name.
To to be consistent with electron/electron-i18n.

@zeke

zeke approved these changes Nov 17, 2017

@jkleinsc jkleinsc merged commit 6fab8cc into electron:master Nov 17, 2017

5 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 17, 2017

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Nov 17, 2017

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment