New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setApplicationMenu/getApplicationMenu docs #11167

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@simast
Contributor

simast commented Nov 19, 2017

Minor improvement to menu module documentation. This fixes issue with generated TypeScript typings, where previously you had to use any as a workaround:

// Before:
Menu.setApplicationMenu(null as any);

// After:
Menu.setApplicationMenu(null);

@simast simast requested a review from electron/docs as a code owner Nov 19, 2017

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 19, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Nov 19, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Nov 20, 2017

Member

Hmm, windows ci didn't run here 🤔

Member

codebytere commented Nov 20, 2017

Hmm, windows ci didn't run here 🤔

@simast

This comment has been minimized.

Show comment
Hide comment
@simast

simast Nov 20, 2017

Contributor

@codebytere I have included [ci skip] in the commit message as specified in the CONTRIBUTING file. Could this somehow be related?

Contributor

simast commented Nov 20, 2017

@codebytere I have included [ci skip] in the commit message as specified in the CONTRIBUTING file. Could this somehow be related?

@ckerr

ckerr approved these changes Nov 20, 2017

Thanks!

@ckerr ckerr merged commit 432d050 into electron:master Nov 20, 2017

5 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 20, 2017

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Nov 20, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@simast simast deleted the simast:menu-typings-fix branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment