New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize README.md headers #11170

Merged
merged 3 commits into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@him2him2
Contributor

him2him2 commented Nov 19, 2017

Small changes to standardize formatting.

Standardize README.md headers
Small changes to standardize formatting.

@him2him2 him2him2 requested a review from electron/reviewers as a code owner Nov 19, 2017

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Nov 19, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Nov 19, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@him2him2 him2him2 changed the title from :memo: Standardize README.md headers to Standardize README.md headers Nov 19, 2017

Show outdated Hide outdated README.md

him2him2 added some commits Nov 19, 2017

@zeke

zeke approved these changes Nov 20, 2017

@ckerr ckerr merged commit 0711e1e into electron:master Nov 20, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment