New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md URLs to HTTPS #11217

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
4 participants
@him2him2
Contributor

him2him2 commented Nov 22, 2017

Updating HTTP protocol to HTTPS on applicable URLS

@him2him2 him2him2 requested a review from electron/reviewers as a code owner Nov 22, 2017

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Nov 22, 2017

Member

This CI failure seems to clearly be unrelated to the, the issue is lint failures in upgrading-chrome.md and this PR's changes are in README.md.

This PR looks fine to me but before we merge let's see if we can resolve the test failures separately. I'm also curious how we got master into this state in the first place.

Member

ckerr commented Nov 22, 2017

This CI failure seems to clearly be unrelated to the, the issue is lint failures in upgrading-chrome.md and this PR's changes are in README.md.

This PR looks fine to me but before we merge let's see if we can resolve the test failures separately. I'm also curious how we got master into this state in the first place.

@him2him2

This comment has been minimized.

Show comment
Hide comment
@him2him2

him2him2 Nov 22, 2017

Contributor

@ckerr Yes, I noticed the build error when I created this PR.

Looks like #11191 (which was merged about 10 hrs ago) introduced the code that was not passing CI on master. However, that PR shows no build error. Not sure why.

Once #11218 is merged, I will re-push my commits for this PR and they should pass.

Contributor

him2him2 commented Nov 22, 2017

@ckerr Yes, I noticed the build error when I created this PR.

Looks like #11191 (which was merged about 10 hrs ago) introduced the code that was not passing CI on master. However, that PR shows no build error. Not sure why.

Once #11218 is merged, I will re-push my commits for this PR and they should pass.

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Nov 22, 2017

Member

Sounds good.

I've merged #11218 if you want to re-push

Member

ckerr commented Nov 22, 2017

Sounds good.

I've merged #11218 if you want to re-push

Update README.md URLs to HTTPS
Updating HTTP protocol to HTTPS on applicable URLS
[ci skip]
@him2him2

This comment has been minimized.

Show comment
Hide comment
@him2him2

him2him2 Nov 22, 2017

Contributor

Tests passed.
As a note, there are transient timeout errors in the CI scripts. Sometimes it fails and sometimes it doesn't.

Contributor

him2him2 commented Nov 22, 2017

Tests passed.
As a note, there are transient timeout errors in the CI scripts. Sometimes it fails and sometimes it doesn't.

@zeke

zeke approved these changes Nov 22, 2017

Looks good to me

@codebytere codebytere merged commit 96aa0aa into electron:master Nov 23, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@him2him2 him2him2 deleted the him2him2:_fix_README.md_HTTPS branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment