New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous-integration build error #11218

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@him2him2
Contributor

him2him2 commented Nov 22, 2017

Added Missing code-language flags

@him2him2 him2him2 requested a review from electron/docs as a code owner Nov 22, 2017

@him2him2 him2him2 changed the title from fix continuous-integration build error to Fix continuous-integration build error Nov 22, 2017

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Nov 22, 2017

Member

Ah I should've checked the rest of my inbox! This is the kind of fix I was referring to in my comment in your other PR :)

The CI has failed here too, but looking at the logs it's not clear to me why -- it looks like all the actual node tests passed.

However @him2him2 I do have a change request, please specify sh instead of bash in this patch. Pushing that change will have the bonus side effect of re-running CI so we can see if appveyor's issues persist...

Member

ckerr commented Nov 22, 2017

Ah I should've checked the rest of my inbox! This is the kind of fix I was referring to in my comment in your other PR :)

The CI has failed here too, but looking at the logs it's not clear to me why -- it looks like all the actual node tests passed.

However @him2him2 I do have a change request, please specify sh instead of bash in this patch. Pushing that change will have the bonus side effect of re-running CI so we can see if appveyor's issues persist...

fix continuous-integration build error
Added Missing code-language flags to upgrading-chrome.md
@him2him2

This comment has been minimized.

Show comment
Hide comment
@him2him2

him2him2 Nov 22, 2017

Contributor

@ckerr it passes now. Thank.

Contributor

him2him2 commented Nov 22, 2017

@ckerr it passes now. Thank.

@ckerr

ckerr approved these changes Nov 22, 2017

@ckerr ckerr merged commit fded32d into electron:master Nov 22, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment