New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: BrowserView.getAllViews() & BrowserView.fromWebContents() #11225

Merged
merged 6 commits into from Nov 23, 2017

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Nov 23, 2017

Users used to throwing around BrowserWindows were limited by having less features available on the BrowserView. This PR brings them up to par.

  • BrowserView.getAllViews() and BrowserView.getFromWebContents(), both implemented exactly like their BrowserWindow counterparts.
  • Docs and tests.

Closes ##11132

@felixrieseberg felixrieseberg requested review from electron/browserview as code owners Nov 23, 2017

@felixrieseberg felixrieseberg changed the title from feat: BrowserView.getAllViews() & BrowserView.fromWebContents() to feature: BrowserView.getAllViews() & BrowserView.fromWebContents() Nov 23, 2017

@poiru

poiru approved these changes Nov 23, 2017

Thank you!

@ckerr

ckerr approved these changes Nov 23, 2017

@ckerr ckerr merged commit 3c60739 into master Nov 23, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@ckerr ckerr deleted the get-current-browser-view branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment