New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanded release docs #11328

Merged
merged 15 commits into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Dec 4, 2017

I'm attempting to make my first Electron release and have hit a couple of missing instructions and also some incorrect assumptions on my part. This branch expands the release.md documentation to fill in these gaps.

I'll remove the [WIP] status after the release is done, but welcome comments at any point.

Special thanks to @jkleinsc for a lot of help :)

@ckerr ckerr requested a review from electron/docs as a code owner Dec 4, 2017

@ckerr ckerr changed the title from [WIP] expand release docs to expanded release docs Dec 5, 2017

@ckerr ckerr requested a review from jkleinsc Dec 5, 2017

@zeke

zeke approved these changes Dec 5, 2017

Few little things, but overall looks good 👍

@@ -201,8 +251,34 @@ the correct checksums as specified in the SHASUMS files.
## Publish to npm
Once the publish is successful, run `npm run publish-to-npm` to publish to
release to npm.
Before publishing to npm, you'll need to log into npm as Electron. Optionally,

This comment has been minimized.

@zeke

zeke Dec 5, 2017

Member

log into npm as electron

@zeke

zeke Dec 5, 2017

Member

log into npm as electron

Show outdated Hide outdated docs/development/releasing.md
@jkleinsc

@ckerr overall looks good to me. I have a PR open to update this doc (#11154), maybe we should combine them? I'm happy to add my changes to this branch.

Show outdated Hide outdated docs/development/releasing.md

ckerr added some commits Mar 7, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 7, 2018

Member

Wow, I had forgotten this PR existed.

At first I was wondering if it was even worth keeping after all this time, but as I read it I realized that I'd forgotten half of these things -- so it's probably worth dusting off and trying to land again 😄

Member

ckerr commented Mar 7, 2018

Wow, I had forgotten this PR existed.

At first I was wondering if it was even worth keeping after all this time, but as I read it I realized that I'd forgotten half of these things -- so it's probably worth dusting off and trying to land again 😄

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Mar 21, 2018

Member

@jkleinsc bump 😄

Member

ckerr commented Mar 21, 2018

@jkleinsc bump 😄

@jkleinsc

@ckerr overall, looks good to me, just some slight tweaks needed.

Show outdated Hide outdated docs/development/releasing.md
Show outdated Hide outdated docs/development/releasing.md
Show outdated Hide outdated docs/development/releasing.md
@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Apr 13, 2018

Member

@jkleinsc, I didn't see your responses to this -- I really should tend these old pulls more often! I've done some copyediting here to address your suggestions. Thanks!

Member

ckerr commented Apr 13, 2018

@jkleinsc, I didn't see your responses to this -- I really should tend these old pulls more often! I've done some copyediting here to address your suggestions. Thanks!

@jkleinsc jkleinsc merged commit 717f55b into master Apr 18, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Apr 18, 2018

Member

🎄

Member

zeke commented Apr 18, 2018

🎄

@alexeykuzmin alexeykuzmin deleted the add-env-to-release-docs branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment