New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly cleanup in `removeAsDefaultProtocolClient` #11329

Merged
merged 10 commits into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented Dec 4, 2017

As it turns out, when I first built removeAsDefaultProtocolClient, I didn't really cleanup after ourselves. This PR fixes that, ensuring that calling those two commands doesn't leave garbage in the registry:

1️⃣ setAsDefaultProtocolClient('foo')
2️⃣ removeAsDefaultProtocolClient('foo')

Thanks to @juturu for noticing.

Closes #9944

felixrieseberg added some commits Dec 2, 2017

@felixrieseberg felixrieseberg requested a review from electron/reviewers as a code owner Dec 4, 2017

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Dec 4, 2017

Member

@felixrieseberg, would it be difficult to add tests for this cleanup?

Member

ckerr commented Dec 4, 2017

@felixrieseberg, would it be difficult to add tests for this cleanup?

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Dec 4, 2017

Member

@ckerr It's possible, but only if we add a new generic "read the registry" module so that we can verify that the registry is clean after running removeAsDefaultProtocolClient('foo'). We could also shell out to powershell to confirm that it actually worked.

Thoughts? Happy to write one!

Member

felixrieseberg commented Dec 4, 2017

@ckerr It's possible, but only if we add a new generic "read the registry" module so that we can verify that the registry is clean after running removeAsDefaultProtocolClient('foo'). We could also shell out to powershell to confirm that it actually worked.

Thoughts? Happy to write one!

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Dec 5, 2017

Member

Yes, sounds good to me.

Member

ckerr commented Dec 5, 2017

Yes, sounds good to me.

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Dec 5, 2017

Member

@ckerr Detailed tests added!

Member

felixrieseberg commented Dec 5, 2017

@ckerr Detailed tests added!

felixrieseberg added some commits Dec 5, 2017

@ckerr

ckerr approved these changes Dec 6, 2017

Great work. Thanks for the tests.

@ckerr ckerr merged commit 5fa29fc into master Dec 6, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@ckerr ckerr deleted the remove-classes-key branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment