New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly cleanup in `removeAsDefaultProtocolClient` #11329

Merged
merged 10 commits into from Dec 6, 2017

👷 Linter fascism

  • Loading branch information...
felixrieseberg committed Dec 5, 2017
commit d519bfc5fba1dcee02e3c7fa02661ec3b64656fe
Copy path View file
@@ -558,8 +558,12 @@ describe('app module', () => {
it('creates a registry entry for the protocol class', (done) => {
app.setAsDefaultProtocolClient(protocol)
classesKey.keys((error, keys) => {
if (error) {
throw error
}
const exists = !!keys.find((key) => key.key.includes(protocol))
assert.equal(exists, true)
@@ -570,11 +574,15 @@ describe('app module', () => {
it('completely removes a registry entry for the protocol class', (done) => {
app.setAsDefaultProtocolClient(protocol)
app.removeAsDefaultProtocolClient(protocol)
classesKey.keys((error, keys) => {
if (error) {
throw error
}
const exists = !!keys.find((key) => key.key.includes(protocol))
assert.equal(exists, false)
done()
})
})
@@ -591,9 +599,13 @@ describe('app module', () => {
app.removeAsDefaultProtocolClient(protocol)
classesKey.keys((error, keys) => {
if (error) {
throw error
}
const exists = !!keys.find((key) => key.key.includes(protocol))
assert.equal(exists, true)
done()
})
})
ProTip! Use n and p to navigate between commits in a pull request.