New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --chromium_dir argument to script/create-dist.py #11354

Merged
merged 2 commits into from Feb 5, 2018

Conversation

Projects
None yet
4 participants
@elegos
Contributor

elegos commented Dec 6, 2017

Fixes #11353

This patch adds --chromium_dir to specify a custom libchromiumcontent dist folder (i.e. ./script/create-dist.py --chromium_dir /my/libchromiumcontent/dist/static_library)

@elegos elegos requested a review from electron/reviewers as a code owner Dec 6, 2017

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Dec 6, 2017

Is this different from the existing --libcc_static_library_path argument?

parser.add_argument('--libcc_source_path', required=False,

@elegos

This comment has been minimized.

Contributor

elegos commented Dec 6, 2017

@MarshallOfSound it is, as the bootstrap's argument is not taken in consideration. I'm not a python expert, so I haven't invastigated more than the create-dist.py script (which has the chromium content dir hardened into the code).

Maybe the create-dist script may take in consideration the bootstrap's variables, but I'm not sure how the bootstrap passes the variables.

@MarshallOfSound MarshallOfSound requested a review from zcbenz Dec 6, 2017

@codebytere

This comment has been minimized.

Member

codebytere commented Dec 15, 2017

@elegos builds are failing on lint, please npm run lint and commit associated changes!

@elegos

This comment has been minimized.

Contributor

elegos commented Dec 16, 2017

@codebytere thanks for the reply :)

Honestly I'm confused about the docs lint fail, as I modified no readme or doc, but only the python script, which I fixed the CS problem already. I'll try sync'ing the project again and see if it will fix itself.

@zcbenz

zcbenz approved these changes Feb 5, 2018

@zcbenz zcbenz merged commit 28d96e2 into electron:master Feb 5, 2018

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

welcome bot commented Feb 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment