New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow testing of single spec modules #11409

Merged
merged 6 commits into from Dec 28, 2017

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Dec 11, 2017

This PR allows you to run npm run test -match=menu, which will then only run spec modules matching menu. This is crazy useful for anyone who's working on tests that would otherwise be at the very end of the testing cycle.

Also: I've used the opportunity to upgrade the JavaScript in index.html to ES6 and StandardJS, in line with our coding standards.

@felixrieseberg felixrieseberg requested a review from electron/reviewers as a code owner Dec 11, 2017

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Dec 11, 2017

Member

if i could hug this PR i would

Member

codebytere commented Dec 11, 2017

if i could hug this PR i would

Show outdated Hide outdated spec/static/index.html
@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Dec 12, 2017

Member

We should probably also write this hot trick down somewhere, but I'm not sure where. Any tips? New file?

Member

felixrieseberg commented Dec 12, 2017

We should probably also write this hot trick down somewhere, but I'm not sure where. Any tips? New file?

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Dec 12, 2017

Member

build-system-overview.md#tests sounds like a good place for this One Simple Trick

Member

ckerr commented Dec 12, 2017

build-system-overview.md#tests sounds like a good place for this One Simple Trick

@ckerr

ckerr approved these changes Dec 12, 2017

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Dec 12, 2017

Member

@felixrieseberg What do you think about build-system-overview.md#tests?

Member

ckerr commented Dec 12, 2017

@felixrieseberg What do you think about build-system-overview.md#tests?

@felixrieseberg felixrieseberg requested review from electron/docs as code owners Dec 28, 2017

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Dec 28, 2017

Member

@ckerr @codebytere Happy new year! It took me a while, but I finally came around to adding some docs.

I noticed that we don't really have any testing docs, so I took the liberty of creating a new top-level document. Changes/corrections welcome!

Member

felixrieseberg commented Dec 28, 2017

@ckerr @codebytere Happy new year! It took me a while, but I finally came around to adding some docs.

I noticed that we don't really have any testing docs, so I took the liberty of creating a new top-level document. Changes/corrections welcome!

@codebytere

LGTM 🎉

@codebytere codebytere merged commit 5f4b62b into master Dec 28, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@alexeykuzmin alexeykuzmin deleted the selective-spec branch Jan 2, 2018

kwonoj added a commit to kwonoj/electron that referenced this pull request Jan 25, 2018

feat: Allow testing of single spec modules (electron#11409)
* 🔧 ES6 for the spec

* 👷 Allow testing of single modules

* ❤️ Implement feedback

* 📝 Add a testing doc

* 📝 Link to it

* 📝 Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment