New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually set spellchecker for sub frames in 1.8.x #11489

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
3 participants
@deepak1556
Copy link
Member

deepak1556 commented Dec 20, 2017

Backports #11238

Refs #11147

@deepak1556 deepak1556 requested a review from electron/reviewers as a code owner Dec 20, 2017

@deepak1556 deepak1556 force-pushed the 1-8-spellchecker-iframe-patch branch from 5682648 to d0a9379 Dec 20, 2017

@deepak1556 deepak1556 requested a review from ckerr Dec 20, 2017

@ckerr

ckerr approved these changes Dec 20, 2017

Copy link
Member

ckerr left a comment

🎉

@ckerr ckerr merged commit 19d70e5 into 1-8-x Dec 20, 2017

6 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented Dec 20, 2017

@deepak1556, thanks for the 1-8-x backport!

By any chance do you have time to backport #11385 and electron/libchromiumcontent#417?

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Dec 20, 2017

to backport #11385

@deepak1556
This is non-trivial btw. In the 1-8-x branch we still have async menus, while in the master we don't.

@alexeykuzmin alexeykuzmin deleted the 1-8-spellchecker-iframe-patch branch Dec 20, 2017

@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Dec 21, 2017

By any chance do you have time to backport #11385 and electron/libchromiumcontent#417?

Sure, I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment