New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bluetooth chooser bug. Closes #11399 #11492

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@timmyhadwen
Contributor

timmyhadwen commented Dec 21, 2017

Added a callback for select-bluetooth-device via Emit calls. Fixes 1 minute timeout when searching for bluetooth devices. Closes #11399.

  • bluetooth_chooser.cc

@timmyhadwen timmyhadwen requested a review from electron/reviewers as a code owner Dec 21, 2017

@welcome

This comment has been minimized.

welcome bot commented Dec 21, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@zcbenz

zcbenz approved these changes Feb 5, 2018

I'm not quite sure whether this is the best solution, but it shouldn't make things worse, let's have a try.

@zcbenz zcbenz merged commit 42fa018 into electron:master Feb 5, 2018

5 of 6 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@welcome

This comment has been minimized.

welcome bot commented Feb 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment