New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license year #11545

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
7 participants
@m1guelpf
Contributor

m1guelpf commented Dec 31, 2017

TO DO:

  • Wait to the next year (100% done, depends on timezone)
  • Merge!

:octocat:

@m1guelpf m1guelpf requested a review from electron/reviewers as a code owner Dec 31, 2017

@welcome

This comment has been minimized.

welcome bot commented Dec 31, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jan 1, 2018

/cc @lee-dohm We used to only have a single year in the license file, I can't remember the discussion around this but could we just make it 2013 or 2013-present, updating the year every year is extra work and adds nothing to the license. If anything having an "end year" on the license is a Bad Thing(tm) 😄

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Jan 1, 2018

@MarshallOfSound we set it up this way based on advice from one of our awesome legal folks that know a lot more about licensing than I ever will 😀 I believe technically we should wait until there is a code change before updating the year, we shouldn't just update the year because the year changed.

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jan 1, 2018

@lee-dohm Gotcha, makes sense 👍 Will just leave this one hanging until the first 2018 commit goes in then 😄

@sdbedi

This comment has been minimized.

sdbedi commented Jan 3, 2018

@lee-dohm Might be safe to run that point by an attorney to be sure - I don't see how the two are linked.

I know that Facebook uses -Present format for their open source projects. I trust their lawyers ;p

@sdbedi

This comment has been minimized.

sdbedi commented Jan 3, 2018

@lee-dohm My apologies, on further research, I see you may be right.

@zeke

zeke approved these changes Jan 4, 2018

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Jan 10, 2018

Looks like there's been a code change. Thanks for the help!

@lee-dohm lee-dohm merged commit f596253 into electron:master Jan 10, 2018

5 of 6 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

welcome bot commented Jan 10, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@m1guelpf m1guelpf deleted the m1guelpf-forks:patch-1 branch Jan 12, 2018

@mickaelandrieu

This comment has been minimized.

mickaelandrieu commented Feb 22, 2018

@sdbedi can you provide a link about it? I've never seen a proof of an advantage of date range instead of the initial date of creation :)

@phillip-haydon

This comment has been minimized.

phillip-haydon commented Feb 22, 2018

@mickaelandrieu seems like it doesn't really matter based on this:

https://softwareengineering.stackexchange.com/questions/130478/what-copyright-date-for-an-update-to-an-open-source-project-from-last-year

It seems like wasted effort to me, but I'm no copyright expert so that's just an opinion :)

@sdbedi

This comment has been minimized.

sdbedi commented Feb 23, 2018

@mickaelandrieu

Strictly speaking, copyright notice is not required under U.S. law:
https://en.wikipedia.org/wiki/Copyright_notice

However, a couple of sources suggest that a date range is the best practice for continuously updated source materials, ie. source code:
http://epiphany.law/articles/copyright/copyright-dates-single-year-or-range
http://smallbusiness.chron.com/year-copyright-statement-mean-62027.html
https://www.copyrightlaws.com/copyright-notice-year/

DISCLAIMER: The above is not intended as legal advice. You should consult your own attorney if you require legal advice personalized to your situation.

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Feb 23, 2018

I think we should avoid legal speculation in the discussions here. As @sdbedi pointed out, anyone interested should consult their own attorney for legal advice.

I appreciate that you state that you're an attorney in your profile @sdbedi but I would feel more comfortable if discussions of legal matters occurred in a more formal setting than in a random issue conversation 😀 Because of this, I'm going to lock this for further comments.

Thanks everyone for your feedback.

@electron electron locked as off topic and limited conversation to collaborators Feb 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.