Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes hexColorDWORDToRGBA for transparent colors #11557
Fixes issue #11556
Uses 0-padding and a set width 8 characters of ensure that RGBA hexadecimal colors string representations are unambiguous.
e.g. (A: 00, R: 0, G: 0, B: 255) is now unambiguously printed as
Replaces janky string substring and concatenation based ARGB -> RGBA shifting logic with bitwise operations to fix several bugs.
The previous code resulted in colors with low-alpha or R-channel values being printed incorrectly. For example, previously
(A: 0, R: 0, G: 160, B: 0) (ARGB: 0x0000A000) would be rendered as RGBA
Here is a list of things that will help get it across the finish line: